[#119] Add registration as a sole voter #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJaroszczak
requested review from
MSzalowski,
Sworzen1 and
kickloop
as code owners
Closed
MSzalowski
approved these changes
Feb 26, 2024
CHANGELOG.md
Outdated
| @@ -9,11 +9,14 @@ As a minor extension, we also keep a semantic version for the `UNRELEASED` | |||
| changes. | |||
|
|
|||
| ## [Unreleased] | |||
| - Add retire as Sole Voter screen [Issue 198](https://github.com/IntersectMBO/govtool/issues/198) | |||
| - Add Sole Voter card [Issue 141](https://github.com/IntersectMBO/govtool/issues/141) | |||
There was a problem hiding this comment.
You can move all the unreleased changes to the proper section.
MSzalowski
force-pushed
the
feat/119-i-want-to-vote-on-behalf-of-myself-become-a-drep
branch
from
9aacf83 to
2119010
Compare
|
Changed to DRAFT as I've resolved conflicts to develop, but I need to dive deeper if they are resolved correctly and anything important is not omitted. |
MSzalowski
added this to the I want to vote on behalf of myself (Become a Sole Voter) milestone
MSzalowski
changed the title
|
@JanJaroszczak Please have a look if after rebase to develop nothing has been lost |
Sworzen1
reviewed
Feb 27, 2024
| color="primary" | ||
| sx={{ | ||
| fontWeight: 400, | ||
| paddingTop: "1px", |
Sworzen1
reviewed
Feb 27, 2024
| @@ -116,7 +112,7 @@ export const DashboardActionCard: FC<DashboardActionCardProps> = ({ | |||
| ) : null} | |||
| {inProgress && !isLoading ? ( | |||
| <Typography variant="title2" fontWeight={700}> | |||
| in progress | |||
| In Progress | |||
| @@ -142,7 +142,7 @@ export const VoteActionForm = ({ | |||
| /> | |||
| </Box> | |||
| </Box> | |||
| {dRep?.isRegistered && ( | |||
| {voter?.isRegisteredAsDRep && ( | |||
| @@ -134,7 +134,7 @@ export const DashboardGovernanceActionDetails = () => { | |||
| ? formatDisplayDate(state.expiryDate) | |||
| : formatDisplayDate(data.proposal.expiryDate) | |||
| } | |||
| isDRep={dRep?.isRegistered} | |||
| isDRep={voter?.isRegisteredAsDRep} | |||
| @@ -121,7 +121,7 @@ export const DashboardGovernanceActions = () => { | |||
| sortingActive={Boolean(chosenSorting)} | |||
| sortOpen={sortOpen} | |||
| /> | |||
| {dRep?.isRegistered && ( | |||
| {voter?.isRegisteredAsDRep && ( | |||
| @@ -47,6 +49,7 @@ export const DashboardTopNav = ({ | |||
| zIndex={100} | |||
| flex={1} | |||
| width={"fill-available"} | |||
| height={"48px"} | |||
There was a problem hiding this comment.
We needed to implement isVotingPowerHidden and when turning this on the navbar height was changing unnecessarily. With height added, the navbar height stays the same.
| @@ -215,7 +215,7 @@ export const DelegateTodRepStepOne = ({ setStep }: DelegateProps) => { | |||
| flexDirection={"column"} | |||
| rowGap={3} | |||
| > | |||
| {dRep?.isRegistered && currentDelegation !== dRepID && ( | |||
| {voter?.isRegisteredAsDRep && currentDelegation !== dRepID && ( | |||
| const { t } = useTranslation(); | ||
|
|
||
| useEffect(() => { | ||
| if ( |
There was a problem hiding this comment.
it can be helper checkIsWalletConnected
Sworzen1
approved these changes
Feb 27, 2024
Extend the drep/info endpoint by adding isRegisteredAsSoleVoter and wasRegisteredAsSoleVoter fields
MSzalowski
deleted the
feat/119-i-want-to-vote-on-behalf-of-myself-become-a-drep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
That will close
#119
#141
#143
#144
#121
#198
#210
#212
#214
Checklist