-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: #161, #301, #291, #198, #143, #121, #119, #210, #246, #214, #141, #144, #212, #316 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment This commit updates the user_data.sh script within the Terraform modules for govtool-EC2 instances. It adds Michał Szałowski to the list of users authorized for SSH access, thereby expanding the secure access management system to include a team leader. This change is a step towards fulfilling the secure credential sharing acceptance criterion by ensuring new team members like Michał have the necessary access to sensitive environments.
Extend the drep/info endpoint by adding isRegisteredAsSoleVoter and wasRegisteredAsSoleVoter fields
Signed-off-by: jankun4 <michaljankun@gmail.com>
Signed-off-by: jankun4 <michaljankun@gmail.com>
Updated CSP settings in Traefik configuration for beta, dev, staging, and test environments to include Sentry's domain without the ingest subdomain. This change permits Sentry error logging and reporting to function correctly without being blocked by the CSP. The adjustment ensures Sentry can capture and report runtime errors, facilitating better monitoring and debugging capabilities across our development, testing, and staging phases. - Modified CSP `connect-src` directive to set `o4506155985141760.ingest.sentry.io` replacing old Sentry sources. - Ensured that the updated settings adhere to our security policies by only allowing necessary and trusted sources. This update addresses the need for comprehensive error reporting through Sentry, enhancing our ability to quickly identify and resolve issues in our application's environments.
This commit introduces a significant update to the `.env.example` file within the `scripts/govtool` directory to enhance usability and prevent configuration mistakes. Key changes include: - Addition of Vim modeline at the beginning of the file (`# vim: set ft=bash`) to ensure that when editing the file with Vim, the correct filetype (bash) is automatically set. This facilitates syntax highlighting and other filetype-specific features, improving the editing experience. - Introduction of a conditional warning mechanism that activates when the environment is not set to 'dev'. This mechanism employs bash scripting to alert to users, especially those working in non-development environments, to proceed with caution and be aware of their current configuration context. The warning message explicitly states the current environment value, reinforcing the need for attentiveness. These enhancements are designed to minimize the risk of misconfiguration by providing clear, environment-specific warnings and improving file readability and editing support.
Signed-off-by: jankun4 <michaljankun@gmail.com>
MSzalowski
requested review from
Sworzen1,
JanJaroszczak and
kickloop
as code owners
February 28, 2024 10:59
MSzalowski
changed the title
test: #161, #301
test: #161, #301, #291, #198, #143, #121, #119, #210, #246, #214, #141, #144, #212, #316
Feb 28, 2024
SandraRodziewicz
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
#161
#301
#291
#198
#143
#121
#119
#210
#246
#214
#141
#144
#212
#316