feat/364-information-storage-steps #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sworzen1
requested review from
MSzalowski,
JanJaroszczak and
kickloop
as code owners
MSzalowski
requested changes
Mar 7, 2024
| generateJsonBody, | ||
| getValues, | ||
| watch, | ||
| } = useCreateGovernanceActionForm(); |
There was a problem hiding this comment.
That most likely will be moved to Governance Provider which would also include logic for hashing metadata & validation of metadata submitted to some storage by user.
|
|
||
| // TODO: change link when available | ||
| const openLink = () => { | ||
| openInNewTab("https://www.google.com"); |
There was a problem hiding this comment.
Replace it with https://docs.sanchogov.tools in case it is forgotten
| @@ -26,9 +30,28 @@ export const useCreateGovernanceActionForm = () => { | |||
| reset, | |||
| } = useFormContext<createGovernanceActionValues>(); | |||
|
|
|||
| const onSubmit = useCallback(async () => { | |||
| setIsLoading(true); | |||
| const generateJsonBody = (data: createGovernanceActionValues) => { | |||
There was a problem hiding this comment.
To be replaced with .jsonld with preset default CIP columns and body based on the governance action type.
| const jsonString = `data:text/json;chatset=utf-8,${encodeURIComponent(json)}`; | ||
| const link = document.createElement("a"); | ||
| link.href = jsonString; | ||
| link.download = `${fileName ? fileName : "data"}.json`; |
There was a problem hiding this comment.
the fileName should be replaced with governance action type eg.: treasury-withdrawal.jsonld
MSzalowski
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
add storage information screens
only uI without build metadata and metadata hash:
#378
Checklist