Hotfix for 'why' debug option in make #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit corrects the debug option in make commands in the CI/CD pipeline workflow, so that the deployment process in the CI can execute without issues related to unrecognized debug flags. The existing 'make' commands were utilizing the debug flag '--debug=w' which was causing compatibility issues in the CI environment where 'why' debug option was not recognized. This commit addresses the problem by replacing the 'w' with 'b' in the relevant 'make' commands in the '.github/workflows/build-and-deploy.yml' file, ensuring smooth execution of the deployment tasks.
placek
requested review from
MSzalowski
and removed request for
kickloop and
adgud
|
https://github.com/IntersectMBO/govtool/actions/runs/8199642385/job/22425062963 here is example of passing deploy from this branch. Previously the deploy failed: https://github.com/IntersectMBO/govtool/actions/runs/8199282654 |
MSzalowski
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the debug option in make commands in the CI/CD pipeline workflow, so that the deployment process in the CI can execute without issues related to unrecognized debug flags.
The existing 'make' commands were utilizing the debug flag '--debug=w' which was causing compatibility issues in the CI environment where 'why' debug option was not recognized. This commit addresses the problem by replacing the 'w' with 'b' in the relevant 'make' commands in the '.github/workflows/build-and-deploy.yml' file, ensuring smooth execution of the deployment tasks.