Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA submitter complete flow #474

Merged
merged 11 commits into from
Mar 14, 2024
Merged

GA submitter complete flow #474

merged 11 commits into from
Mar 14, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

Important note to QA

  • Feedback button on validation modal is not handled yet (it navigates back)
  • Info icons on gov action types are not handled yet as point in docs is not existing
  • amount and receiving address are not yet an array of elements - as they are not designed yet

Checklist

JanJaroszczak and others added 11 commits March 12, 2024 14:09
To ensure frontend image builds can distinguish between different
environments, an additional distinction based on the environment tag has
been introduced. This change was necessary as the commit altering the
frontend module alone was insufficient. By adding an environment tag to
the image tag name, applications with the same version can now be
uniquely identified across various environments.

Changes Made:
- Modified the Makefile in the govtool/frontend directory to introduce
  an environment tag to the image tag name used in frontend image
  builds. The new tag is generated by appending the environment variable
  to the commit hash obtained from the git log command, ensuring each
  build is uniquely identified per environment.
…-compose-stack-for-proper-frontend-image-tagging

[#466] Enhancing Docker Compose stack for proper frontend image tagging
…n-of-the-metadata

[#378] feat: add hash and validation of the metadata
@pmbinapps pmbinapps merged commit 451feba into test Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants