Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#501] fix sql error #502

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Mar 18, 2024

fix sql error that could occur when there would be no voting power for predefined dreps

List of changes

  • Fix
    fix possible error that could occur when predefined drep would have no voting power

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

fix sql error that could occur when there would be no voting power for predefined dreps

Signed-off-by: jankun4 <michaljankun@gmail.com>
@jankun4 jankun4 force-pushed the 501-proposal-and-network-metrics-endpoints-break-when-network-has-no-predefined-dreps branch from a16ea5e to febdfd3 Compare March 18, 2024 20:14
@jankun4 jankun4 requested a review from Ryun1 March 18, 2024 20:16
@@ -32,6 +32,7 @@ changes.

### Fixed

- Fix possible sql error when there would be no predefined drep voting pwoer [Issue 501](https://github.com/IntersectMBO/govtool/issues/501)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix possible sql error when there would be no predefined drep voting pwoer [Issue 501](https://github.com/IntersectMBO/govtool/issues/501)
- Fix possible sql error when there would be no predefined drep voting power [Issue 501](https://github.com/IntersectMBO/govtool/issues/501)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@jankun4 jankun4 merged commit efd1556 into develop Mar 18, 2024
@jankun4 jankun4 deleted the 501-proposal-and-network-metrics-endpoints-break-when-network-has-no-predefined-dreps branch March 18, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal and network metrics endpoints break when network has no predefined DReps
3 participants