Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#512] chore: add type checking & lint workflow to github actions #513

Merged

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Mar 19, 2024

List of changes

  • add type checking & linting to github actions

Note

That workflow won't work without #511
Also, that workflow will fail until lint errors and type errors are fixed.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Mar 19, 2024 that may be closed by this pull request
@adgud
Copy link
Contributor

adgud commented Mar 19, 2024

Why a separate workflow instead of including this in the testing one that you've just created?

@MSzalowski
Copy link
Contributor Author

Why a separate workflow instead of including this in the testing one that you've just created?

You are right, separation makes no sense as we want to have all the checks to be passed.

@placek
Copy link
Contributor

placek commented Mar 19, 2024

Why a separate workflow instead of including this in the testing one that you've just created?

Double that: it can be a parallel job to be done in the same workflow.

Copy link
Contributor

@placek placek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eslint, tsc and prettier to github actions
3 participants