-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#512] chore: add type checking & lint workflow to github actions #513
[#512] chore: add type checking & lint workflow to github actions #513
Conversation
Why a separate workflow instead of including this in the testing one that you've just created? |
You are right, separation makes no sense as we want to have all the checks to be passed. |
Double that: it can be a parallel job to be done in the same workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
ee89d91
to
7a5d234
Compare
List of changes
Note
That workflow won't work without #511
Also, that workflow will fail until lint errors and type errors are fixed.
Checklist