Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Gov Actions #525

Merged
merged 5 commits into from
Mar 26, 2024
Merged

New Gov Actions #525

merged 5 commits into from
Mar 26, 2024

Conversation

JanJaroszczak
Copy link
Contributor

@JanJaroszczak JanJaroszczak commented Mar 20, 2024

  • New UI of Governance Actions

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@JanJaroszczak JanJaroszczak force-pushed the gov-actions-new branch 5 times, most recently from ad4dddc to 9f74b25 Compare March 24, 2024 22:41
@JanJaroszczak JanJaroszczak requested a review from jdyczka March 24, 2024 22:42
@JanJaroszczak JanJaroszczak marked this pull request as ready for review March 24, 2024 22:42
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall - it looks pretty solid - good job 💪

I request only for the small changes except stories which I think, should be always current to the current state.

govtool/frontend/src/components/atoms/IconLink.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/SliderArrow.tsx Outdated Show resolved Hide resolved
govtool/frontend/public/icons/Separator.svg Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/Tooltip.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/components/molecules/SliderArrows.tsx Outdated Show resolved Hide resolved
@Sworzen1
Copy link
Contributor

At the end, please create new section - context for vote with all steps, you can follow existed components

@Sworzen1 Sworzen1 self-requested a review March 25, 2024 16:15
@JanJaroszczak JanJaroszczak force-pushed the gov-actions-new branch 2 times, most recently from a23e9ab to 6d92332 Compare March 25, 2024 18:56
@JanJaroszczak JanJaroszczak merged commit 2512248 into develop Mar 26, 2024
4 checks passed
@JanJaroszczak JanJaroszczak deleted the gov-actions-new branch March 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants