-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Gov Actions #525
Merged
Merged
New Gov Actions #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJaroszczak
force-pushed
the
gov-actions-new
branch
5 times, most recently
from
March 24, 2024 22:41
ad4dddc
to
9f74b25
Compare
JanJaroszczak
requested review from
MSzalowski,
Sworzen1 and
kickloop
as code owners
March 24, 2024 22:42
MSzalowski
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall - it looks pretty solid - good job 💪
I request only for the small changes except stories which I think, should be always current to the current state.
govtool/frontend/src/components/molecules/GovernanceActionCardElement.tsx
Show resolved
Hide resolved
govtool/frontend/src/components/molecules/GovernanceActionCardElement.tsx
Outdated
Show resolved
Hide resolved
govtool/frontend/src/components/organisms/GovernanceActionDetailsCard.tsx
Outdated
Show resolved
Hide resolved
Sworzen1
suggested changes
Mar 25, 2024
At the end, please create new section - context for vote with all steps, you can follow existed components |
JanJaroszczak
force-pushed
the
gov-actions-new
branch
2 times, most recently
from
March 25, 2024 18:56
a23e9ab
to
6d92332
Compare
MSzalowski
approved these changes
Mar 26, 2024
Sworzen1
approved these changes
Mar 26, 2024
JanJaroszczak
force-pushed
the
gov-actions-new
branch
from
March 26, 2024 09:56
6d92332
to
18c34c5
Compare
JanJaroszczak
force-pushed
the
gov-actions-new
branch
from
March 26, 2024 10:17
18c34c5
to
2f64bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist