Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#500] chore: fix frontend package tests #538

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[#500] chore: fix frontend package tests #538

merged 2 commits into from
Mar 25, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • fix frontend package tests
  • add missing utils tests

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Mar 22, 2024 that may be closed by this pull request
Frontend package tests are broken #500
Closed
@MSzalowski MSzalowski force-pushed the chore/500-frontend-package-tests-are-broken branch from 0dd2cfa to 6e6c294 Compare March 22, 2024 16:02
@MSzalowski MSzalowski requested review from placek and adgud as code owners March 22, 2024 17:06
placek
placek approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@placek placek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSzalowski MSzalowski merged commit 176cac2 into develop Mar 25, 2024
@MSzalowski MSzalowski deleted the chore/500-frontend-package-tests-are-broken branch March 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@kickloop kickloop Awaiting requested review from kickloop

@adgud adgud Awaiting requested review from adgud adgud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend package tests are broken
2 participants
@MSzalowski @placek