Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#536] GA search on BE #565

Merged
merged 2 commits into from
Mar 27, 2024
Merged

[#536] GA search on BE #565

merged 2 commits into from
Mar 27, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Mar 26, 2024 •
edited
Loading

List of changes

  • Move handling GA search from FE to BE
  • Make filter and search components reusable

Checklist

  • 536
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka added the 🖥 Frontend Frontend related label Mar 26, 2024
@jdyczka jdyczka self-assigned this Mar 26, 2024
@jdyczka jdyczka linked an issue Mar 26, 2024 that may be closed by this pull request
GA Display: Search, Filter, and Sort #536
Closed
MSzalowski
MSzalowski approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, good job 💪

govtool/frontend/src/hooks/queries/useGetProposalsQuery.ts Show resolved Hide resolved
@jdyczka jdyczka force-pushed the feat/536-ga-search branch from 4368909 to 8380cb6 Compare March 26, 2024 23:57
@jdyczka jdyczka merged commit ebe8f41 into develop Mar 27, 2024
4 checks passed
@jdyczka jdyczka deleted the feat/536-ga-search branch March 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanJaroszczak JanJaroszczak JanJaroszczak approved these changes

@MSzalowski MSzalowski MSzalowski approved these changes

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@kickloop kickloop Awaiting requested review from kickloop

Assignees

@jdyczka jdyczka

Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GA Display: Search, Filter, and Sort
4 participants
@jdyczka @MSzalowski @JanJaroszczak @j-dyczka