Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#541] fix dashboard infinite loading #579

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Mar 27, 2024

List of changes

  • Fix infinite loading on dashboard

Checklist

  • 541
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka added the 🖥 Frontend Frontend related label Mar 27, 2024
@jdyczka jdyczka self-assigned this Mar 27, 2024
@jdyczka jdyczka force-pushed the fix/541-dashboard-infinite-loading branch from 3f62209 to a415aba Compare March 27, 2024 16:38
@Sworzen1
Copy link
Contributor

Why we need compare to undefined ?

@jdyczka
Copy link
Contributor Author

jdyczka commented Mar 28, 2024

Why we need compare to undefined ?

Because with this condition if (!currentDelegation || !voter || !votingPower), if votingPower was 0, or if currentDelegation was null, the loader was still displayed, even though the query was resolved

@jdyczka jdyczka merged commit f19d3b1 into develop Mar 28, 2024
4 checks passed
@jdyczka jdyczka deleted the fix/541-dashboard-infinite-loading branch March 28, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 Frontend Frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants