Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/535-ga-display-display-warning-if-metadata-is-not-in-the-expected-format #598

Merged
merged 4 commits into from
Apr 2, 2024
Merged

feat/535-ga-display-display-warning-if-metadata-is-not-in-the-expected-format #598

merged 4 commits into from
Apr 2, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Mar 29, 2024 •
edited
Loading

List of changes

  • add function which checks the GA metadata is valid

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 linked an issue Mar 29, 2024 that may be closed by this pull request
GA Display: Display Warning if Metadata is not in the Expected Format #535
Closed
@Sworzen1 Sworzen1 marked this pull request as ready for review March 29, 2024 15:43
@Sworzen1 Sworzen1 requested a review from Ryun1 as a code owner March 29, 2024 15:59
MSzalowski
MSzalowski approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As metadata validation tool is already on in progress, you can omit my comment - LGTM, good job 💪

govtool/frontend/src/components/molecules/DataMissingInfoBox.tsx
[GAMetedataErrors.NOT_VERIFIABLE]: t(
"errors.gAMetadata.message.notVerifiable",
),
}[isDataMissing as GAMetedataErrors];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would split this property to be either boolean or enum if that is easy applicable.
If not - leave a TODO to replace that when our minimal metadata validation backend is ready

@Sworzen1 Sworzen1 merged commit 0f35aa6 into develop Apr 2, 2024
4 checks passed
@Sworzen1 Sworzen1 deleted the feat/535-ga-display-display-warning-if-metadata-is-not-in-the-expected-format branch April 2, 2024 09:06
@pmbinapps pmbinapps mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GA Display: Display Warning if Metadata is not in the Expected Format
2 participants
@Sworzen1 @MSzalowski