Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#610] feat: add metadata-validation config in docker-compose.yml.tpl #613

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[#610] feat: add metadata-validation config in docker-compose.yml.tpl #613

merged 1 commit into from
Apr 3, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • rename the submission-tool folder to metadata-validation
  • add infrastructure config of metadata-validation in docker-compose.yml.tpl
  • remove ping in health check to return just the status of a service

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Apr 3, 2024 that may be closed by this pull request
Set up metadata validation service traefik in docker compose template #610
Closed
@MSzalowski MSzalowski requested review from placek and removed request for Sworzen1 and JanJaroszczak April 3, 2024 10:02
placek
placek approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@placek placek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's deploy it on dev.

@MSzalowski MSzalowski merged commit e86b481 into develop Apr 3, 2024
@MSzalowski MSzalowski deleted the chore/610-set-up-metadata-validation-service-traefik-in-docker-compose-template branch April 3, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up metadata validation service traefik in docker compose template
2 participants
@MSzalowski @placek