Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#617] feat: integrate frontend with metadata validation service #619

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[#617] feat: integrate frontend with metadata validation service #619

merged 1 commit into from
Apr 8, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • integrate frontend with metadata validation service
  • change get validate endpoint to post validate endpoint
  • replace all the validateMetadataHash with validateHash mutation

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Apr 3, 2024 that may be closed by this pull request
Integrate frontend with metadata validation service #617
Closed
@MSzalowski MSzalowski force-pushed the feat/617-integrate-frontend-with-metadata-validation-service branch from 4a1c680 to b12a3b6 Compare April 3, 2024 16:59
@MSzalowski
Copy link
Contributor Author

@placek @Sworzen1 I'll need approval from both of you as this PR introduces changes to the infrastructure and frontend

@MSzalowski MSzalowski force-pushed the feat/617-integrate-frontend-with-metadata-validation-service branch 4 times, most recently from 94f3ec7 to 260e26c Compare April 4, 2024 08:30
@MSzalowski
Copy link
Contributor Author

To not break something before releasing the ga display - I'll merge it after GA Display close on test

@MSzalowski MSzalowski force-pushed the feat/617-integrate-frontend-with-metadata-validation-service branch from 260e26c to 82c80b6 Compare April 8, 2024 06:58
@MSzalowski MSzalowski merged commit 7f439dc into develop Apr 8, 2024
6 checks passed
@MSzalowski MSzalowski deleted the feat/617-integrate-frontend-with-metadata-validation-service branch April 8, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sworzen1 Sworzen1 Sworzen1 approved these changes

@placek placek placek approved these changes

@adgud adgud Awaiting requested review from adgud adgud is a code owner

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate frontend with metadata validation service
3 participants
@MSzalowski @placek @Sworzen1