Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/605-ga-display-searching-misleading-text-when-no-items-are-found #623

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix/605-ga-display-searching-misleading-text-when-no-items-are-found #623

merged 1 commit into from
Apr 4, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Apr 4, 2024 •
edited
Loading

List of changes

  • Fix copy for empty GAs category state

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 linked an issue Apr 4, 2024 that may be closed by this pull request
GA Display - Searching - View all - misleading text when no items are found #605
Closed
@Sworzen1 Sworzen1 marked this pull request as ready for review April 4, 2024 11:32
@MSzalowski MSzalowski merged commit 40c9eac into develop Apr 4, 2024
4 checks passed
@MSzalowski MSzalowski deleted the fix/605-ga-display-searching-misleading-text-when-no-items-are-found branch April 4, 2024 15:09
@pmbinapps pmbinapps mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GA Display - Searching - View all - misleading text when no items are found
2 participants
@Sworzen1 @MSzalowski