-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/532-home-page-on-2560-and-1920-resolutions #625
fix/532-home-page-on-2560-and-1920-resolutions #625
Conversation
@@ -32,7 +32,19 @@ export const Hero = () => { | |||
flexDirection="row" | |||
overflow="visible" | |||
position="relative" | |||
px={screenWidth < 640 ? 3 : screenWidth < 1512 ? 10 : 14} | |||
px={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand but when we see the blocks like this there is a place for questions. We won't handle the breakpoints now as we are going to migrate to the components library, but for the stake of a clarity - please lift up this nested ternaries above to not chain so much in the render.
At this moment it might be just the inner function that returns the px value eg.:
const getSize = useCallback(() => {
if (screenWidth < 640) return 3
...
return 49.25}, [screenWidth])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oki doki, i will
: screenWidth >= 860 | ||
? -(IMAGE_SIZE / 8) | ||
: -(IMAGE_SIZE / 4) | ||
screenWidth <= 860 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why on the above nested ternaries we are checking 640, 1512, 1728, 1920, 2560 and here we are checking 860, 1440, 1728? Why it can't be unified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not necessary to check every resolution
List of changes
Checklist