Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/669-update-delegate-card #671

Merged
merged 5 commits into from
Apr 10, 2024
Merged

chore/669-update-delegate-card #671

merged 5 commits into from
Apr 10, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Apr 8, 2024 •
edited
Loading

List of changes

  • update delegation card

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 added the 🖥 Frontend Frontend related label Apr 8, 2024
@Sworzen1 Sworzen1 linked an issue Apr 8, 2024 that may be closed by this pull request
Update delegate card #669
Closed
@Sworzen1 Sworzen1 marked this pull request as ready for review April 8, 2024 22:15
MSzalowski
MSzalowski approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - optional TODO to be added

govtool/frontend/src/components/organisms/AutomatedVotingOptions.tsx Show resolved Hide resolved
govtool/frontend/src/components/organisms/DashboardCards/DRepDashboardCard.tsx
@@ -41,6 +41,9 @@ export const DRepDashboardCard = ({
),
};

const navigateToDrepDirectory = () =>
navigate(PATHS.dashboardDRepDirectoryDRep.replace(":dRepId", dRepIDBech32));

const cardProps: Partial<DashboardActionCardProps> = (() => {
// transaction in progress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment might be deleted in favor of renaming the inProgress to isTransactionInProgress if just the inProgress is not clear - up to you

@Sworzen1 Sworzen1 merged commit 711d3a4 into develop Apr 10, 2024
4 checks passed
@Sworzen1 Sworzen1 deleted the chore/669-update-delegate-card branch April 10, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update delegate card
2 participants
@Sworzen1 @MSzalowski