Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#715] Dev environment load balancing and routing issue #728

Merged

Conversation

placek
Copy link
Contributor

@placek placek commented Apr 15, 2024

Closes #715.

The PR resolves the user story regarding the load balancing and routing issue in the dev environment by providing necessary modifications. It focuses on fixing the Traefik configuration to ensure proper load balancing and routing in the backend services. The changes involve implementing healthchecks, adjusting routing priorities, updating the Traefik image version, fixing indentation, and renaming router names in the docker-compose.yml.tpl file. These modifications aim to establish efficient backend service management within the Traefik load balancer, improving routing efficiency, ensuring service availability, and optimizing traffic allocation. The enhancements directly address the user story's requirements for correct backend service configuration, reachability, and functionality in the dev environment, enabling effective testing and debugging capabilities.

placek added 5 commits April 15, 2024 15:14
…names

The commit adjusts the names of the routers in the Traefik configuration
within the docker-compose.yml file. This modification ensures that the
routers are distinctively named and do not share names with the
services, enhancing clarity and manageability of the setup. By renaming
the router identifiers, it becomes easier to differentiate them from the
corresponding services, thus facilitating maintenance and
troubleshooting of the configuration.
The adjustments in this commit focus on correcting the indentation in
the Traefik configuration section within the docker-compose.yml.tpl
file. The changes entail ensuring consistent and proper alignment of the
services' definitions, specifically the metadata-validation service, to
enhance readability and maintainability. By reformatting the
indentation, the Traefik configuration becomes more organized,
facilitating easier navigation and understanding of the setup.
The commit modifies the Traefik image version specified in the
docker-compose.yml.tpl file from v2.10 to v3.0. By updating the Traefik
image, we ensure compatibility with the necessary features and
improvements introduced in version 3.0. This adjustment aligns with the
user story's goal to enhance load balancing and routing setup in the dev
environment by making sure that the configuration utilizes the latest
Traefik version for more efficient backend service management and
testing capabilities.
The commit enhances the routing setup in the Traefik configuration
within the docker-compose.yml.tpl file by implementing better
priorities. By adjusting the priority of the router for the frontend
service to 1, the routing for this service looses precedence, ensuring
that frontend traffic is correctly directed. This change aims to
optimize the routing logic, ensuring that the frontend service receives
appropriate traffic allocation and improving the overall efficiency of
the load balancing and routing setup in the dev environment.

This is an actual fix of the problem stated in the related issue.
…d balancer

The commit enhances the Traefik configuration within the
docker-compose.yml.tpl file by adding healthcheck configurations to the
two primary backend services, `metadata-validation` and `backend`. These
healthchecks include defining paths, ports, intervals, and timeouts for
monitoring the health and status of the backend services. By
implementing healthchecks, Traefik can periodically verify the
availability and responsiveness of the backend services through
specified endpoints, contributing to improved load balancing and routing
efficiency. This change directly addresses the user story requirement to
ensure the backend service is correctly defined, reachable, and
functioning optimally in the dev environment for effective testing and
debugging purposes.
@placek placek self-assigned this Apr 15, 2024
@placek placek requested review from Ryun1 and MSzalowski as code owners April 15, 2024 13:16
@placek placek linked an issue Apr 15, 2024 that may be closed by this pull request
6 tasks
@placek placek added 🐛 Bug Something isn't working 🏗 Infrastructure labels Apr 15, 2024
@placek placek requested a review from adgud April 15, 2024 13:17
The changes made in this commit focus on enhancing the CORS
configuration for the dev environment by adding an additional exception
to allow specific origins. The modification includes appending
"http://localhost:5173" to the list of allowed hosts when the
environment is set to "dev." This adjustment aims to address
Cross-Origin Resource Sharing (CORS) issues related to accessing
services from different origins, ensuring that the specified host is
permitted to interact with the backend service seamlessly.
@placek placek merged commit cc64e97 into develop Apr 16, 2024
@placek placek deleted the fix/715-dev-environment-load-balancing-and-routing-issue branch April 16, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🏗 Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev environment load balancing and routing issue
2 participants