Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#712] fix: Fix displaying Governance Actions that fails the validation test #730

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[#712] fix: Fix displaying Governance Actions that fails the validation test #730

merged 1 commit into from
Apr 16, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • make validation service the proxy for validating the metadata against CIP-108 which makes the usage of unblocking some resources on CSP no longer needed.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Apr 15, 2024 that may be closed by this pull request
GAs fails validation due to fetching the resource blocked by CSP #712
Closed
@MSzalowski MSzalowski force-pushed the fix/712-gas-fails-validation-due-to-fetching-the-resource-blocked-by-csp branch from 6257966 to b55aca2 Compare April 16, 2024 07:11
@MSzalowski MSzalowski merged commit 0002e4d into develop Apr 16, 2024
6 checks passed
@MSzalowski MSzalowski deleted the fix/712-gas-fails-validation-due-to-fetching-the-resource-blocked-by-csp branch April 16, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sworzen1 Sworzen1 Sworzen1 approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GAs fails validation due to fetching the resource blocked by CSP
2 participants
@MSzalowski @Sworzen1