Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

226 retire dreps who delegate to another drep #882

Merged
merged 4 commits into from
Apr 30, 2024
Merged

226 retire dreps who delegate to another drep #882

merged 4 commits into from
Apr 30, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Apr 29, 2024 •
edited
Loading

List of changes

  • change way to add certs

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 linked an issue Apr 29, 2024 that may be closed by this pull request
Retire DReps who delegate to another DRep #226
Closed
MSzalowski
MSzalowski approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, however my voting power is not being calculated. I think that we can merge it to develop making it able to be tested in a more natural environment having in mind that this change might not fix it.

Looking good to me 💪

@MSzalowski MSzalowski marked this pull request as ready for review April 30, 2024 09:20
@Sworzen1 Sworzen1 merged commit 46270af into develop Apr 30, 2024
4 checks passed
@Sworzen1 Sworzen1 deleted the 226-retire-dreps-who-delegate-to-another-drep branch April 30, 2024 10:26
@pmbinapps pmbinapps mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retire DReps who delegate to another DRep
2 participants
@Sworzen1 @MSzalowski