Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/878-change-padding-on-button #892

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix/878-change-padding-on-button #892

merged 3 commits into from
Apr 30, 2024

Conversation

vercia
Copy link
Collaborator

@vercia vercia commented Apr 30, 2024 •
edited
Loading

List of changes

  • Change - move isLoading props to custom button, remove LoadingButton component
  • Fix padding on buttons

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@vercia vercia changed the title change padding on buttons; remove LoadingButton and add isLoading pro… fix/878-change-padding-on-button Apr 30, 2024
@vercia vercia linked an issue Apr 30, 2024 that may be closed by this pull request
padding on buttons too small on DRep list #878
Closed
@vercia vercia added the 🖥 Frontend Frontend related label Apr 30, 2024
@vercia vercia merged commit f51d4fe into develop Apr 30, 2024
4 checks passed
@vercia vercia deleted the fix/878-change-padding-on-button branch April 30, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sworzen1 Sworzen1 Sworzen1 approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

padding on buttons too small on DRep list
2 participants
@vercia @Sworzen1