chore/898-wrapper-wrap-up-wallet-interface-into-package-and-export-out #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sworzen1
changed the title
MSzalowski
approved these changes
May 7, 2024
| } | ||
| }; | ||
|
|
||
| const disconnectWallet = () => { |
There was a problem hiding this comment.
If we have enableWallet it would be nice to have it called disableWallet for consistency
| cip: number; | ||
| }; | ||
|
|
||
| export type TWalletAPI = { |
There was a problem hiding this comment.
Why is it called TWalletAPI with T at the beginning?
There was a problem hiding this comment.
If T is before name I know thats type for WalletAPI
Sworzen1
deleted the
chore/898-wrapper-wrap-up-wallet-interface-into-package-and-export-out
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist