Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalTxMonitor: Add support for GetMeasures #4918

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fraser-iohk
Copy link

@fraser-iohk fraser-iohk commented Jul 26, 2024

Description

This PR adds a new message to LocalTxMonitor, GetMeasures, which is similar to GetSize (returning the current mempool transaction count, the size of those transactions, and the total mempool capacity), but returns information about several other metrics in addition to the byte size and capacity of the mempool. GetMeasures currently returns size and capacity information for transaction byte size, ledger's execution units (both their memory and execution steps), and the reference scripts size, but can easily be extended to support any new metric types in future while remaining backwards compatible.

This change works towards ouroboros-consensus#1178, and has a dependent PR in ouroboros-consensus

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@fraser-iohk fraser-iohk force-pushed the fraser-iohk/localtxmonitor-measures branch from 9488451 to d6eb7bb Compare September 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants