From c3d596b81c0f32ea55bd936e645be1e0d727e91d Mon Sep 17 00:00:00 2001
From: Peter Kurhajec <61538034+PTKu@users.noreply.github.com>
Date: Mon, 16 Oct 2023 10:27:09 +0200
Subject: [PATCH] 247  new feature we will need a way to provide information
 about culture for localized plc strings (#249)

* Create draft PR for #247

* add methods and modifies to provide localized tranlsation usingmethods

* mend

* fix parent object resource search

---------

Co-authored-by: PTKu <PTKu@users.noreply.github.com>
---
 .../AXSharp - Backup.Abstractions.csproj      | 60 -------------------
 .../AXSharp.Connector/Connector/Connector.cs  |  5 +-
 .../Localizations/Translator.cs               | 12 ++--
 3 files changed, 6 insertions(+), 71 deletions(-)
 delete mode 100644 src/AXSharp.abstractions/src/AXSharp.Abstractions/AXSharp - Backup.Abstractions.csproj

diff --git a/src/AXSharp.abstractions/src/AXSharp.Abstractions/AXSharp - Backup.Abstractions.csproj b/src/AXSharp.abstractions/src/AXSharp.Abstractions/AXSharp - Backup.Abstractions.csproj
deleted file mode 100644
index 1a7e5cc4..00000000
--- a/src/AXSharp.abstractions/src/AXSharp.Abstractions/AXSharp - Backup.Abstractions.csproj	
+++ /dev/null
@@ -1,60 +0,0 @@
-<Project Sdk="Microsoft.NET.Sdk">
-	<PropertyGroup>
-		<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
-
-		<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
-
-		<GenerateDocumentationFile>true</GenerateDocumentationFile>
-		<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
-	  
-		<!--NuGet Specific part-->
-	    <Description>Contains abstractions for AX#</Description>
-
-	    <!-- NuGet Common part-->
-	    <PackageProjectUrl>https://github.com/ix-ax/</PackageProjectUrl>
-	    <RepositoryUrl>https://github.com/ix-ax/axsharp</RepositoryUrl>
-	    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
-	    <Authors>ix-ax</Authors>
-		<Copyright>(c) Peter Kurhajec and Contributors</Copyright>
-		<PackageTags>simatix-ax, PLC, industrial automation, SCADA, HMI</PackageTags>
-	    <GenerateDocumentationFile>true</GenerateDocumentationFile>
-	    <Title>AXSharp abstractions</Title>
-	    <PackageIcon>icon_128_128.png</PackageIcon>
-	    <RepositoryType>git</RepositoryType>
-	    <IncludeSymbols>True</IncludeSymbols>
-	    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
-	    <PackageLicenseExpression>MIT</PackageLicenseExpression>
-	    <PackageReleaseNotes>
-		    Release notes are published here:
-			https://github.com/ix-ax/axsharp/releases
-	    </PackageReleaseNotes>
-	    <PackageReadmeFile>NUGET-README.md</PackageReadmeFile>
-	</PropertyGroup>
-
-  <ItemGroup>
-    <None Include="..\..\..\..\assets\icons\icon_128_128.png">
-      <Pack>True</Pack>
-      <PackagePath>\</PackagePath>
-    </None>
-    <None Include="..\..\..\NUGET-README.md">
-      <Pack>True</Pack>
-      <PackagePath>\</PackagePath>
-    </None>
-  </ItemGroup>
-
-  <ItemGroup>
-    <PackageReference Include="GitVersion.MsBuild" Version="5.10.3">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
-  </ItemGroup>
-
-  <ItemGroup>
-    <ProjectReference Include="..\..\..\AXSharp.connectors\src\AXSharp.Connector\AXSharp.Connector.csproj" />
-  </ItemGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">    
-    <DebugType>Full</DebugType>
-  </PropertyGroup>
-
-</Project>
diff --git a/src/AXSharp.connectors/src/AXSharp.Connector/Connector/Connector.cs b/src/AXSharp.connectors/src/AXSharp.Connector/Connector/Connector.cs
index bd8f55f6..defe3b94 100644
--- a/src/AXSharp.connectors/src/AXSharp.Connector/Connector/Connector.cs
+++ b/src/AXSharp.connectors/src/AXSharp.Connector/Connector/Connector.cs
@@ -386,13 +386,12 @@ protected async void StartReadWriteOps()
         var sw = new Stopwatch();
         long cycleCount = 0;
         var startTimeStamp = DateTime.Now;
-
+        
         await Task.Run(async () =>
-        {            
+        {
             while (true)
                 if (!IsRwLoopSuspended)
                 {
-                    //Thread.Sleep(ReadWriteCycleDelay);
                     await Task.Delay(ReadWriteCycleDelay);
                     sw.Restart();
                     try
diff --git a/src/AXSharp.connectors/src/AXSharp.Connector/Localizations/Translator.cs b/src/AXSharp.connectors/src/AXSharp.Connector/Localizations/Translator.cs
index b313353a..40100fb3 100644
--- a/src/AXSharp.connectors/src/AXSharp.Connector/Localizations/Translator.cs
+++ b/src/AXSharp.connectors/src/AXSharp.Connector/Localizations/Translator.cs
@@ -21,7 +21,7 @@ public class Translator
         
         private ResourceManager _resourceManager;
 
-        private CultureInfo Culture = new CultureInfo("sk-SK");
+        private CultureInfo Culture = CultureInfo.InvariantCulture;
 
         /// <summary>
         /// Translates localized string.
@@ -33,11 +33,7 @@ public string Translate(string originalString, ITwinElement twin, CultureInfo cu
         {
             if(culture == null) culture = Culture;
 
-            if (_resourceManager == null)
-            {
-                return originalString.CleanUpLocalizationTokens();
-            }
-
+            
             return Localize(originalString, twin, culture);
         }
 
@@ -119,13 +115,13 @@ private string LocalizeInParents(string token, ITwinElement rootObj, CultureInfo
 
         public string Localize(string str, ITwinElement twinElement, CultureInfo culture)
         {
-            Console.WriteLine($"{str}");
+            
             foreach (var localizable in GetTranslatable(str))
             {
                 var validIdentifier = LocalizationHelper.CreateId(localizable.CleanUpLocalizationTokens());
 
                 // Search in first level resource
-                var translation = _resourceManager.GetString(validIdentifier, culture);
+                var translation = _resourceManager?.GetString(validIdentifier, culture);
                 
                 // Search in parent resources
                 if (translation == null)