-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persian translations added #321
Conversation
Hello @arashveysi3. Thank you for your contribution I have a question. Am I right that Persian alphabet has right-to-left direction and right text alignment? If yes, I have a request to you. Could you please run peri locally on your laptop and show us the problems with current UI which should be fixed according to right-to-left alphabet? Of course in case if you are a native speaker and this is will not be difficult for you You just need to exexute To mark problems in the app you can use any image editor. I can recommend https://excalidraw.com as example |
Hey @imblowfish Thanks for reviewing my PR. the problem exists in all of the pages but as an example I took a screenshot of the main page https://excalidraw.com/#room=cc4fb9147c008706c73e,GJ9evYHPhNV-zwVIkDJDiw |
@imblowfish according to comment on the IraSoro#321 PR.
Thank you! We'll create additional ticket for rtl interface support. Until this, could you please move Persian language to the Beta languages? We'll return it back later And we could probably need your help. Can we tag you to check the fixes in the future? |
per discussion with @imblowfish, the app currently doesn't supports RTL languages. so it must be in Beta languages section for now
Yes why not! Persian language moved to Beta language section for now. let's say mission accomplished! |
@IraSoro review plz |
@arashveysi3, thank you for your interest in the project and for the work you've done! Congratulations on your first contribution to |
Added Persian translations fully according to Contriibution.MD instructions.
plus I updated Readme.MD (Persian included in supported languages)
open to future contributions and thanks for your great application. 💯
Hope it helps!