Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persian translations added #321

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Persian translations added #321

merged 3 commits into from
Nov 15, 2024

Conversation

arashveysi3
Copy link
Contributor

Added Persian translations fully according to Contriibution.MD instructions.
plus I updated Readme.MD (Persian included in supported languages)
open to future contributions and thanks for your great application. 💯
Hope it helps!

src/utils/translations/fa.ts Outdated Show resolved Hide resolved
@imblowfish
Copy link
Collaborator

imblowfish commented Nov 14, 2024

Hello @arashveysi3. Thank you for your contribution

I have a question. Am I right that Persian alphabet has right-to-left direction and right text alignment?

If yes, I have a request to you. Could you please run peri locally on your laptop and show us the problems with current UI which should be fixed according to right-to-left alphabet?

Of course in case if you are a native speaker and this is will not be difficult for you

You just need to exexute npm start and attach screenshot in this PR with your comments

To mark problems in the app you can use any image editor. I can recommend https://excalidraw.com as example

@arashveysi3
Copy link
Contributor Author

Hey @imblowfish Thanks for reviewing my PR.
Yes, you are right in it supposed to be RTL instead of LTR.
Good news is with a little of your guide I can fix it!

the problem exists in all of the pages but as an example I took a screenshot of the main page
as you suggested to me, I used https://excalidraw.com and what a great app!

https://excalidraw.com/#room=cc4fb9147c008706c73e,GJ9evYHPhNV-zwVIkDJDiw

@imblowfish according to comment on the IraSoro#321 PR.
@imblowfish
Copy link
Collaborator

imblowfish commented Nov 15, 2024

Hey @imblowfish Thanks for reviewing my PR.
Yes, you are right in it supposed to be RTL instead of LTR.
Good news is with a little of your guide I can fix it!

the problem exists in all of the pages but as an example I took a screenshot of the main page
as you suggested to me, I used https://excalidraw.com and what a great app!

https://excalidraw.com/#room=cc4fb9147c008706c73e,GJ9evYHPhNV-zwVIkDJDiw

Thank you!

We'll create additional ticket for rtl interface support. Until this, could you please move Persian language to the Beta languages? We'll return it back later

And we could probably need your help. Can we tag you to check the fixes in the future?

src/utils/translation.ts Outdated Show resolved Hide resolved
per discussion with @imblowfish, the app currently doesn't supports RTL languages. so it must be in Beta languages section for now
@arashveysi3
Copy link
Contributor Author

Hey @imblowfish Thanks for reviewing my PR.
Yes, you are right in it supposed to be RTL instead of LTR.
Good news is with a little of your guide I can fix it!
the problem exists in all of the pages but as an example I took a screenshot of the main page
as you suggested to me, I used https://excalidraw.com and what a great app!
https://excalidraw.com/#room=cc4fb9147c008706c73e,GJ9evYHPhNV-zwVIkDJDiw

Thank you!

We'll create additional ticket for rtl interface support. Until this, could you please move Persian language to the Beta languages? We'll return it back later

And we could probably need your help. Can we tag you to check the fixes in the future?

Yes why not! Persian language moved to Beta language section for now. let's say mission accomplished!
I'm open to any further contributions on this project happily. meanwhile I am fluent in Turkish too. and It's a LTR language so I will start to translate app to Turkish too.

@imblowfish
Copy link
Collaborator

@IraSoro review plz

@IraSoro IraSoro added this to the vNext milestone Nov 15, 2024
@IraSoro IraSoro linked an issue Nov 15, 2024 that may be closed by this pull request
@IraSoro IraSoro merged commit 1818e78 into IraSoro:master Nov 15, 2024
1 check passed
@IraSoro
Copy link
Owner

IraSoro commented Nov 15, 2024

@arashveysi3, thank you for your interest in the project and for the work you've done! Congratulations on your first contribution to Peri!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add translation
3 participants