Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rolled node back to 10 from 12 #1

Merged
merged 1 commit into from
May 12, 2020
Merged

rolled node back to 10 from 12 #1

merged 1 commit into from
May 12, 2020

Conversation

ToniaSchlick
Copy link
Contributor

Rolled Node back to 10 because Node 12 broke needle.

@ernieturner
Copy link

Node 12.16.3 broke something with needle, the library that node-pre-gyp ends up using when it attempts to download recrypt-node-bindings. Instead of fixing this action to Node 12.16.2 we decided to go down to Node 10 as it's still an LTS release and will get patch fixes. Hopefully by the time that Node 10 is EOL we'll have a fix on Node 12 and can upgrade then.

@ToniaSchlick ToniaSchlick removed the request for review from cjyar May 12, 2020 17:35
@ToniaSchlick ToniaSchlick merged commit dc71ea9 into master May 12, 2020
@ernieturner ernieturner deleted the nodeIssueFix branch May 12, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernieturner ernieturner ernieturner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ToniaSchlick @ernieturner