Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add option to encode in AdxVersion4 / Add Warning for AdxVersion4 #1

Open
dreamsyntax opened this issue Oct 8, 2021 · 0 comments

Comments

@dreamsyntax
Copy link

Example Source File:

AdxHeader {
    encoding: Standard,
    block_size: 18,
    sample_bitdepth: 4,
    channel_count: 1,
    sample_rate: 24000,
    total_samples: 91968,
    highpass_frequency: 500,
    version: Version4,
    flags: 0
}

Output with encode -n

AdxHeader {
    encoding: Standard,
    block_size: 18,
    sample_bitdepth: 4,
    channel_count: 2,
    sample_rate: 24000,
    total_samples: 91968,
    highpass_frequency: 500,
    version: Version3(
        Some(
            AdxVersion3LoopInfo {
                alignment_samples: 0,
                enabled_short: 0,
                enabled_int: 0,
                begin_sample: 0,
                begin_byte: 0,
                end_sample: 0,
                end_byte: 0
            }
        )
    ),
    flags: 0
}

AdxVersion4 can be decoded just fine, encoding always returns to Version3.

Solution:

  • Add ability to encode to AdxVersion3/4 with flag

I may open a PR if I get around to it.

@dreamsyntax dreamsyntax changed the title Add Warning for AdxVersion4 [Enhancement] Add option to encode in AdxVersion4 / Add Warning for AdxVersion4 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant