-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenJDK or Oracle JDK in Vagrant #289
Comments
We used Oracle for Djatoka right, was there another reason? |
There are differences, perfomance and bug fix stuff |
Any one on http://www.azul.com/downloads/zulu/? |
@whikloj yeah, only for Djatoka on 1.x -- On 2.x, it was just because there wasn't an OpenJDK deb package available for Java 8, and Oracle JDK was it. I'm happy to switch it back. |
.....but, that stackoverflow @DiegoPino linked to is compelling. |
In a way, this is related to #243 |
+1 for OpenJDK |
Consensus for moving back to OpenJDK. I'll get a pull request in shortly. |
I'll take that back, OpenJDK-8 is still problematic on 14.04. I'll say this is dependant on moving Vagrant to 16.04; #181 |
Partially resolved with f942941?? |
@whikloj I'd go with fully resolved. @dannylamb? |
Somewhat unclear at the end of this thread. Sticking with official? And yes, whatever works means this is resolved. |
We had consensus on moving back to OpenJDK, and #323 took care of that, so I'd consider it closed 😄 |
Agreed, I just went back to check this out. You did switch in #323. We are good. |
Good. PR had openjdk, but last comment on this thread made it seem like oracle was the way to go. Thanks for clearing that up. |
Do we want to move to OpenJDK in our Vagrant? Or stick with Oracle JDK?
@DiegoPino @whikloj @br2490 @bryjbrown
The text was updated successfully, but these errors were encountered: