Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSH access command #163

Merged
merged 2 commits into from
Apr 6, 2016
Merged

Update SSH access command #163

merged 2 commits into from
Apr 6, 2016

Conversation

DonRichards
Copy link
Member

Add shorthand command for ssh -p 2222 vagrant@localhost
vagrant ssh
#162 Documentation - SSH Shorthand

Add shorthand command for `ssh -p 2222 vagrant@localhost`
`vagrant ssh` works
@ruebot
Copy link
Member

ruebot commented Mar 8, 2016

Thanks for this @DonRichards! Can you make this consistent with what you did here and also address this comment?

@nigelgbanks
Copy link
Member

Should probably remove:

You can connect to the machine via ssh: `ssh -p 2222 vagrant@localhost`

As the Port will change to a random port if you already have one vagrant instance running that exposes the Guest 22 on the host as 2222.

@ruebot
Copy link
Member

ruebot commented Mar 10, 2016

@DonRichards bump.

@DonRichards
Copy link
Member Author

@nigelgbanks I would suggest leaving only so others with more complicated environments know this is an option. But it could be a side note instead of a key point

@@ -65,6 +65,7 @@ Tomcat Manager:
* password: islandora

You can connect to the machine via ssh: `ssh -p 2222 vagrant@localhost`
Or shorthand `vagrant ssh`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonRichards can you change this into two bullets?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonRichards bump.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there anything else that was needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this moment, no. Before I'll merge this, I'd like to have it formatted correctly, and consistent with this entire section. So, if you can do that, it would be great.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonRichards you got this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatted correctly? The update name description or the actual code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonRichards I'm specifically referring to the bullet points. Right now you have:

screenshot from 2016-04-05 12-44-55

I'm asking that you make it consistent with the rest of the section. Like this:

You can connect to the machine via ssh:

  • ssh -p 2222 vagrant@localhost
  • vagrant ssh

Does that make sense?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

Correct Vagrant SSH formatting to be consistent with the overall formatting standards
Resolved #163
@ruebot ruebot merged commit 88d1f12 into Islandora:7.x-2.x Apr 6, 2016
@DonRichards DonRichards deleted the patch-3 branch April 6, 2016 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants