Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for image fields and multi-file media #2003

Open
dannylamb opened this issue Dec 13, 2021 · 3 comments
Open

Add support for image fields and multi-file media #2003

dannylamb opened this issue Dec 13, 2021 · 3 comments
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)

Comments

@dannylamb
Copy link
Contributor

Right now if you want a derivative to live on the Media, you can only use file fields. With a small change we can add support for image fields, too. That way you can set the thumbnail or give a media an image service file.
@dannylamb dannylamb mentioned this issue Dec 13, 2021
Merged
@kstapelfeldt kstapelfeldt added the Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’) label Jan 5, 2022
@rosiel
Copy link
Member

rosiel commented Jul 24, 2022

Fixed with Islandora/islandora#860

@rosiel rosiel closed this as completed Jul 24, 2022
@ajstanley
Copy link
Contributor

There was already an Action plugin for this.
Here.

@rosiel
Copy link
Member

rosiel commented Jul 25, 2022 •
edited
Loading

I didn't see it because it's within islandora_image, a submodule that I didn't have enabled. My bad...

Unfortunately, the "Generate an Image Derivative for Media Attachment" option also only lets you select file fields - until Islandora/islandora#860.

It appears since this PR hits the parent class, AbstractGenerateDerivativeMediaFile, it also applies to all multi-file media derivatives. I'll work on a fix, if anyone is willing to test?

@rosiel rosiel reopened this Jul 25, 2022
@rosiel rosiel mentioned this issue Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)
Projects
Islandora Issues Queue
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kstapelfeldt @ajstanley @rosiel @dannylamb