Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] WSOD when entity passed to AbstractGenerateDerivativeMediaFile::generateData is not a Media #2152

Closed
seth-shaw-asu opened this issue Aug 9, 2022 · 1 comment
Assignees
Labels
Type: bug identifies a problem in the software with clear steps to reproduce

Comments

@seth-shaw-asu
Copy link
Member

What steps does it take to reproduce the issue?

  • Add a Media derivative action that gets triggered in a Node context. (I don't have a sandbox example as our derivative reaction is a local development)
  • Be greeted with a WSOD.

See details @ asulibraries/islandora-repo#550

TL;DR: AbstractGenerateDerivativeMediaFile::generateData returns nothing if triggered on a Node, but this Null is then passed to the StompHeaderEvent which then chokes and WSODs. A properly configured site shouldn't have this scenario occur, but we should be more forgiving when it does happen by throwing an exception which can be caught and reported more gracefully.

Which version of Islandora are you using?

2.x

Any related open or closed issues to this bug report?

No.

@seth-shaw-asu seth-shaw-asu added the Type: bug identifies a problem in the software with clear steps to reproduce label Aug 9, 2022
@seth-shaw-asu seth-shaw-asu self-assigned this Aug 10, 2022
@seth-shaw-asu
Copy link
Member Author

Resolved with Islandora/islandora@62fbc6d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug identifies a problem in the software with clear steps to reproduce
Projects
None yet
Development

No branches or pull requests

1 participant