Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Image Derivatives could be more efficient #2165

Closed
dannylamb opened this issue Sep 9, 2022 · 2 comments
Closed

PDF Image Derivatives could be more efficient #2165

dannylamb opened this issue Sep 9, 2022 · 2 comments
Labels
Type: bug identifies a problem in the software with clear steps to reproduce

Comments

@dannylamb
Copy link
Contributor

When an image derivative is made for a PDF, the entire PDF is used to generate the image. Every page is taken and then flattened into one image, so it takes a while and the resulting image is oversized. With a small chunk of code, you can say "just use the first page", which yields the exact same derivative, just smaller and faster.

What steps does it take to reproduce the issue?
Upload a 50 MB+ PDF and you'll get slow and oversized derivatives

Which version of Islandora are you using?
2+

Any related open or closed issues to this bug report?
I've already integrated this with ISLE to an extent. If this gets merged I can drop a branch i've got over on isle-buildkit.

@dannylamb dannylamb added the Type: bug identifies a problem in the software with clear steps to reproduce label Sep 9, 2022
@rosiel
Copy link
Member

rosiel commented Sep 14, 2022

It'd be nice to have the page number extracted as an option in the System Action (often ETDs etc have boilerplate cover pages). This'll be a separate issue.

@dannylamb
Copy link
Contributor Author

Closing this and staying tuned to #2168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug identifies a problem in the software with clear steps to reproduce
Projects
None yet
Development

No branches or pull requests

2 participants