Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for Flysystem vs fcrepo urls #2181

Open
ruebot opened this issue Oct 12, 2022 · 1 comment
Open

Add configuration option for Flysystem vs fcrepo urls #2181

ruebot opened this issue Oct 12, 2022 · 1 comment
Labels
Repository:Islandora Issues pertaining to the repository: https://github.com/Islandora/islandora Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)

Comments

@ruebot
Copy link
Member

ruebot commented Oct 12, 2022

Overview of feature request

Currently the URLs passed to the derivative generation services are Flysystem URLs. If an installation is split across multiple machines, this can lead to issues when fcrepo and Crayfish are on one machine, and Drupal is on another. Basically, a derivative for a file might go from machine A to B to A because of this configuration. In this scenario, there really is no reason for the file to go to machine B.

An extremely lazy fix for this is to have a regex on the source or file_url variables in each services Controller to rewrite the URL being passed around. An ideal fix mentioned by @seth-shaw-asu is to modify AbstractGenerateDerivative so that we can have a "Use Fedora URI" checkbox to the configuration forms.

Larger discussion in Slack here

What kind of user is the feature intended for?

Developer, Systems Administrator

What inspired the request?

Derivatives not being generated for large video files.

What existing behavior do you want changed?

Configuration of base url passed to derivative generation services.

Any brand new behavior do you want to add to Islandora?

No.

Any related open or closed issues to this feature request?

No.

@ruebot ruebot added Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’) Repository:Islandora Issues pertaining to the repository: https://github.com/Islandora/islandora labels Oct 12, 2022
@seth-shaw-asu
Copy link
Member

To enhance the idea around the GenerateDerivative option, we would be checking if the file's URI is using a flysystem and then use the flysystem API to get the actual URI and then only use it if it is HTTP resolvable (because flysystem supports things like local Zip file URLs, which obviously won't work for sending to Crayfish). Thanks to @rosiel for prompting that consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Repository:Islandora Issues pertaining to the repository: https://github.com/Islandora/islandora Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)
Projects
None yet
Development

No branches or pull requests

2 participants