Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #38

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Update CONTRIBUTING.md #38

merged 1 commit into from
Sep 2, 2020

Conversation

manez
Copy link

@manez manez commented Aug 24, 2020

GitHub Issue: Islandora/documentation#1588

What does this Pull Request do?

Adds mention of the new User Call to CONTRIBUTING.md.

How should this be tested?

Preview & review

Interested parties

@Islandora/8-x-committers

@rosiel
Copy link

rosiel commented Aug 24, 2020

ugh, got bit by Travis.

PHP Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 4096 bytes) in phar:///home/travis/.phpenv/versions/7.2.33/bin/composer/src/Composer/DependencyResolver/RuleWatchGraph.php on line 52

@manez
Copy link
Author

manez commented Aug 24, 2020

I've restarted Travis a couple of times to the same results

@dannylamb
Copy link

Finally circling back around to this one. Looks like maybe updating how we call composer a la https://github.com/Islandora/documentation/blob/master/.scripts/travis_setup_drupal.sh#L13 should work?

@dannylamb
Copy link

As it stands now, this PR is completely unrelated to the Travis issues, so I'm cool with @rosiel merging it in and we deal with it in a separate PR.

@seth-shaw-unlv seth-shaw-unlv merged commit 465acbc into 8.x-1.x Sep 2, 2020
@seth-shaw-unlv seth-shaw-unlv deleted the manez-patch-contrib branch September 2, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants