Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo to support multiple tracks. #871

Merged
merged 1 commit into from
May 18, 2022

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented May 16, 2022

GitHub Issue: Oral History Transcriptions seems the most relevant

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Attempts at loading multiple tracks into an islandora video for alternate captions/subtitles failed; the problem seems to be an unclosed tag in the twig template.

What's new?

Close the tag in the twig template.

  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? yes, to work as expected

How should this be tested?

  • Add two differently labeled subtitle tracks to an islandora video. Only one will show up. If you inspect the <video> element it'll have a stub <track within the other <track (which wasn't closed properly)
  • With this PR, both should show up and you'll see two <track>s.

Documentation Status

  • Does this change existing behaviour that's currently documented? no, sadly, but that's how I found it.
  • Does this change require new pages or sections of documentation? Working on it.
  • Who does this need to be documented for? Users expecting to add subtitles/captions.
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-unlv seth-shaw-unlv merged commit 0322808 into Islandora:2.x May 18, 2022
@rosiel rosiel deleted the rosiel-tracks branch November 25, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants