Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captions v2 #48

Merged
merged 1 commit into from
Mar 18, 2021
Merged

captions v2 #48

merged 1 commit into from
Mar 18, 2021

Conversation

elizoller
Copy link
Member

@elizoller elizoller commented Mar 9, 2021

GitHub Issue:
Islandora/documentation#1305
Islandora/documentation#1003
https://www.drupal.org/project/drupal/issues/3057144
https://www.drupal.org/project/drupal/issues/3056714

Other Relevant Links
Perhaps superseding https://github.com/Islandora/islandora/pull/743/files
Definitely supersedes #44

What does this Pull Request do?

Takes the work in the patch 16 here https://www.drupal.org/project/drupal/issues/3056714
Allows a user to add a "track" to an audio or video media object which will play in the HTML5 player

What's new?

How should this be tested?

  • spin up an islandora site
  • pull in this islandora_defaults PR and the islandora PR captions v2 islandora#826
  • do a partial config import on the config/install directory of islandora_defaults
  • cache clear
  • add an audio and/or video node
  • add an audio and/or video original file media attached to that node
  • when the service file derivative is created, add a VTT caption file to that service file media in the new track field
  • view the node - in the menu on the HTML5 player, you should be able to toggle on and off captions

Additional Notes

  • this does not have the poster/thumbnail feature i presented in Captions #44

Interested parties

@Islandora/8-x-committers @Natkeeran

@elizoller elizoller changed the title config for captions captions v2 Mar 9, 2021
@elizoller
Copy link
Member Author

pretty sure travis is unhappy because this config relies on code in the other PR: Islandora/islandora#826

@seth-shaw-unlv
Copy link
Contributor

I've restarted the build. Hopefully Travis will be happy this time.

There is a lot of new config here. Should we be including an update hook to add them? Or do we want existing sites to selectively import the new configs they are interested in? We at least need to document how to enable this feature on an existing site (with specifics about what configs are needed) in the release notes.

@seth-shaw-unlv
Copy link
Contributor

So, Travis is going to keep failing until Packagist picks up the new commit on islandora:dev-8.x-1.x. 🙄

@elizoller
Copy link
Member Author

ok, i gave packagist a poke and restarted the build. we'll see. thanks so much for giving this a whirl

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Just be sure to add instructions to the release notes for enabling the feature since we aren't providing an update hook.

@seth-shaw-unlv seth-shaw-unlv merged commit 34accdd into Islandora:8.x-1.x Mar 18, 2021
@elizoller
Copy link
Member Author

@seth-shaw-unlv added notes here Islandora/documentation@17837b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants