Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framer Motion: IE11 Issues #278

Open
ItsJonQ opened this issue Mar 2, 2021 · 5 comments
Open

Framer Motion: IE11 Issues #278

ItsJonQ opened this issue Mar 2, 2021 · 5 comments
Labels
animations bug Something isn't working

Comments

@ItsJonQ
Copy link
Owner

ItsJonQ commented Mar 2, 2021

Looks like Framer Motion is causing IE11 rendering issues:
WordPress/gutenberg#28249

We currently don't use it in many places.. Collapsible is the only one that comes to mind (and Navigator 🙈 )
In that sense, we could remove it 🤔

It would be a shame to lose this library for future animation work.

React Spring is compatible with IE11:
pmndrs/react-spring#552 (comment)

It looks like we're already using it in Gutenberg:
https://github.com/WordPress/gutenberg/blob/da8555d258edbe676fa079fb51252f918ae032e1/packages/block-editor/src/components/block-navigation/leaf.js

@ItsJonQ ItsJonQ added bug Something isn't working animations labels Mar 2, 2021
@ItsJonQ
Copy link
Owner Author

ItsJonQ commented Mar 2, 2021

The main component we rely on Framer Motion for (at the moment) is Collapsible.
Replacing it with react-spring would mean writing something like this:

https://gist.github.com/ItsJonQ/31c470eb64cbce3762db19dd7841206e

Not impossible.. it's just very manual (not to mention direct imperative DOM style manipulation is required)

@ItsJonQ
Copy link
Owner Author

ItsJonQ commented Mar 2, 2021

Refactoring Navigator will be tricky as well... 🙈

@ItsJonQ
Copy link
Owner Author

ItsJonQ commented Mar 2, 2021

@stokesman
Copy link

Have you seen motiondivision/motion#781? I don't think that's made it into their docs yet.

@ItsJonQ
Copy link
Owner Author

ItsJonQ commented Mar 4, 2021

@stokesman I have! I found it when I was reading their much larger issue:
motiondivision/motion#364

I could give this a shot 🙏 . Although, we'd have to figure out polyfills still (since they aren't providing them).. and something to do with code splitting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animations bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants