Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently failing on latest glitch-soc (v4.3.0-alpha.3+glitch) #77

Closed
kescherCode opened this issue May 20, 2024 · 2 comments · Fixed by #78
Closed

Currently failing on latest glitch-soc (v4.3.0-alpha.3+glitch) #77

kescherCode opened this issue May 20, 2024 · 2 comments · Fixed by #78

Comments

@kescherCode
Copy link

I get the following stacktrace on up-to-date glitch-soc based instances:

TypeError: ActionElement.closest(...) is null protootshelpers.js:56:16
    addTypeAttribute protootshelpers.js:56
    addtoTootObserver protoots.js:152
    main protoots.js:107
    forEach self-hosted:157
    main protoots.js:107
@ItsVipra
Copy link
Owner

Thanks for the report keschi <3

Seems like the extension is trying to add pronouns to the indicator showing the currently logged-in user. It matches on the "account" class, which must have been recently added to that element.
Adding a if (hasClasses(ActionElement, "account--minimal")) return; somewhere in the stack should resolve the type error. I'll look for a nice place to put that later today :3

@ItsVipra
Copy link
Owner

In the meantime, I've also noticed that clicking on somebody's username to open their profile and then navigating back causes two ProPlates to be added to some (but not all) usernames 🥴

@ItsVipra ItsVipra linked a pull request May 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants