[BUG] 4 decimal is not enough for crypto

[Jack-Works]

Please confirm the following

• I checked the current issues for duplicate problems

Describe the bug

The exchange rate cannot have more than 4 decimals, so when exchanging JPY for BTC (1 JPY = 0.00000011 BTC), it cannot work correctly.

To Reproduce

No response

Expected behavior

No response

Screenshots

No response

App version

2024.07.06 (181)

Smartphone

No response

Additional context

No response

[ivywallet]

Thank you @Jack-Works for raising Issue #3287! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

[suyash01]

I'm on it

[ivywallet]

Thank you for your interest @suyash01! 🎉
Issue #3287 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

[suyash01]

@ILIYANGERMANOV just changing the decimal place will change it for every currency and usually crypto like ETH can have upto 18 decimal places. So, I was thinking to maintain 2 decimal places - one for crypto and one for normal currency.
However, we don't store the type of currency in either account or exchange rate table. what are your thoughts on this?

[ILIYANGERMANOV]

Hey @suyash01 we have an IvyCurrency class that can differentiate between those. Just create a Set of all supported crypto in Ivy Wallet and if the currency is in that set => use crypto decimals. Also, the UI won't properly display 18 places 😬

[suyash01]

Ok, from UI perspective I am putting the exchange rate to a new line to prevent wrapping.

[Jack-Works]

hi! I'm afraid this issue is not solved. When you edit the exchange rate, you're still being limited to 4 decimals. Please reopen this thank you! cc @ILIYANGERMANOV

[ILIYANGERMANOV]

@suyash01 can you have a look when editing exchange rates?