This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 691
Fix issue 2666 - Releases Screen #2667
Merged
ILIYANGERMANOV
merged 32 commits into
Ivy-Apps:main
from
nicolegeorgieva:fix-issue-2666
Sep 25, 2023
Merged
Fix issue 2666 - Releases Screen #2667
ILIYANGERMANOV
merged 32 commits into
Ivy-Apps:main
from
nicolegeorgieva:fix-issue-2666
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILIYANGERMANOV
suggested changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're making good progress 💯 However, you need to work some more before being ready to merge this feature. Keep the good work 👏
screen-releases/src/main/java/com/ivy/releases/ReleasesContentParser.kt
Outdated
Show resolved
Hide resolved
screen-releases/src/main/java/com/ivy/releases/ReleasesContentParser.kt
Outdated
Show resolved
Hide resolved
screen-releases/src/main/java/com/ivy/releases/ReleasesContentParser.kt
Outdated
Show resolved
Hide resolved
screen-releases/src/main/java/com/ivy/releases/ReleasesContentParser.kt
Outdated
Show resolved
Hide resolved
screen-releases/src/main/java/com/ivy/releases/ReleasesEvent.kt
Outdated
Show resolved
Hide resolved
screen-releases/src/main/java/com/ivy/releases/ReleasesViewModel.kt
Outdated
Show resolved
Hide resolved
screen-releases/src/main/java/com/ivy/releases/ReleasesViewModel.kt
Outdated
Show resolved
Hide resolved
screen-settings/src/main/java/com/ivy/settings/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
UI feedback
|
screen-releases/src/main/java/com/ivy/releases/ReleasesScreen.kt
Outdated
Show resolved
Hide resolved
screen-releases/src/main/java/com/ivy/releases/ReleasesScreen.kt
Outdated
Show resolved
Hide resolved
…etter understanding
…tion to do only side-effects
…ion to do only side-effects
ILIYANGERMANOV
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
main
branch.What's changed?
Describe with a few bullets what's new:
Does this PR closes any GitHub Issues?