This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamim-emon
force-pushed
the
fix-issue-3297
branch
from
August 25, 2024 10:55
90125d2
to
fd2e806
Compare
ILIYANGERMANOV
suggested changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must not change the default design. Instead create a new one and show if a "Compact accounts" feature flag from IvyFeatures
is enabled
ILIYANGERMANOV
added
the
requested changes
Changes are needed. Please, apply them
label
Aug 25, 2024
ILIYANGERMANOV
suggested changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Starts to look good 💯 Left some comments
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
screen/accounts/src/test/java/com/ivy/accounts/AccountsTabPaparazziTest.kt
Show resolved
Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsViewModel.kt
Outdated
Show resolved
Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsViewModel.kt
Outdated
Show resolved
Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsViewModel.kt
Outdated
Show resolved
Hide resolved
screen/accounts/src/main/java/com/ivy/accounts/AccountsState.kt
Outdated
Show resolved
Hide resolved
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
ILIYANGERMANOV
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the CI and we can merge
ILIYANGERMANOV
added
ready to merge 🚀
PR can be merged after the CI pass
and removed
requested changes
Changes are needed. Please, apply them
labels
Aug 25, 2024
Ok will fix it soon! |
ILIYANGERMANOV
approved these changes
Aug 26, 2024
wow, I tried it, it works well, thanks! |
Welcome |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
What's changed?
Describe with a few bullets what's new:
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.