fix-issue-3455

[shamim-emon]

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

• I've read the Contribution Guidelines and my PR doesn't break the rules.
• I've read and understand the Developer Guidelines.
• I confirm that I've run the code locally and everything works as expected.
• My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
• 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

• When we go to transaction details screen from transaction list screen , upon coming back, we loose scroll position. It happens because screens where isLegacy is not true, their viewModel gets cleared as soon as corresponding composable is left out of the screen.

Does this PR close any GitHub issues? (do not delete)

• Closes [BUG] Transaction List Returns to Top Position After Returning from Transaction Detail #3455

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

[shamim-emon]

@ILIYANGERMANOV
Is it okay to mark TransactionsScreen as legacy? It's suggested to not mark Material3 screens with legacy.
Asking this because not sure what's meant by Material3 screens, initially I thought screens which have any material3 component is considered Material3 screen. But then I saw EditTransactionScreen is also marked as legacy even though it contains material3 component.

[ILIYANGERMANOV]

@ILIYANGERMANOV Is it okay to mark TransactionsScreen as legacy? It's suggested to not mark Material3 screens with legacy. Asking this because not sure what's meant by Material3 screens, initially I thought screens which have any material3 component is considered Material3 screen. But then I saw EditTransactionScreen is also marked as legacy even though it contains material3 component.

Idk, just test that it works if that's the case we can merge it

[shamim-emon]

@ILIYANGERMANOV Is it okay to mark TransactionsScreen as legacy? It's suggested to not mark Material3 screens with legacy. Asking this because not sure what's meant by Material3 screens, initially I thought screens which have any material3 component is considered Material3 screen. But then I saw EditTransactionScreen is also marked as legacy even though it contains material3 component.

Idk, just test that it works if that's the case we can merge it

@ILIYANGERMANOV Yes it works, here is the video