Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary/unintentional flushing of the log #31

Open
gri1n opened this issue Feb 13, 2019 · 0 comments
Open

Unnecessary/unintentional flushing of the log #31

gri1n opened this issue Feb 13, 2019 · 0 comments

Comments

@gri1n
Copy link

gri1n commented Feb 13, 2019

It seems like you're using std::endl instead of \n here which includes an implicit flush and then doing a flush a couple of lines below for critical log entries. I'm guessing this use of std::endl was unintentional otherwise the flushing of the critical log entries is entirely pointless because you're flushing every single line already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant