Skip to content

Commit

Permalink
Fix plot logo and tight layout bug (#213)
Browse files Browse the repository at this point in the history
Fix the fatal error that results from a batch plot input yaml file
containing `plot logo` and/or `tight layout` figure settings.

As described in #212 the problem is that in
`src/eva/plotting/batch/base/plot_tools/figure_driver.py` both `plot
logo` and `tight layout` are left in the `figure_conf` dictionary after
the corresponding figure method is correctly applied. The `figure_conf`
dictionary is eventually fed to `emcpy` and then `matplotlib` which is
unable to parse these entries. The fix is to simply remove the entries
from `figure_conf` once the requested method has been called.

Testing has been done on hera using
`src/eva/tests/config/testMonDataSpaceHirs4Metop-A.yaml`, which now can
plot logos and use tight layout.

Closes #212
  • Loading branch information
EdwardSafford-NOAA authored Nov 19, 2024
1 parent 767125f commit a21fce8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
3 changes: 3 additions & 0 deletions src/eva/plotting/batch/base/plot_tools/figure_driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,11 @@ def make_figure(handler, figure_conf, plots, dynamic_options, data_collections,
fig.tight_layout(**figure_conf['tight layout'])
else:
fig.tight_layout()
figure_conf.pop('tight layout')

if 'plot logo' in figure_conf:
fig.plot_logo(**figure_conf['plot logo'])
figure_conf.pop('plot logo')

saveargs = get_saveargs(figure_conf)
fig.save_figure(output_file, **saveargs)
Expand Down
7 changes: 4 additions & 3 deletions src/eva/tests/config/testMonDataSpaceHirs4Metop-A.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ graphics:
figure size: [12,10]
title: 'hirs4_metop-a | Channel 1 | Obs Count'
output name: lineplots/hirs4_metop-a/hirs4_metop-a.0.count.png
#plot logo:
# which: 'noaa/nws'
# loc: 'upper right'
plot logo:
which: 'noaa/nws'
loc: 'upper right'
tight layout:
plots:
- add_xlabel: 'Cycle Time'
add_ylabel: 'Observation Count'
Expand Down

0 comments on commit a21fce8

Please sign in to comment.