Add level components, streamline level, channel, and scan components #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add level components, streamline level, channel, scan.
EdwardSafford-NOAA
requested review from
CoryMartin-NOAA and
kevindougherty-noaa
|
This is an example of the levels in use in an OznMon summary plot:
|
|
I see the documentation failure but I don't understand what's going wrong. The |
|
@asewnath any clues about the EVA documentation test failure? Seems unrelated to this PR |
Rm unnecessary yaxis pseudo-data.
This reverts commit 40b5a49.
Reduce marker psuedo data to single variable.
CoryMartin-NOAA
approved these changes
Aug 25, 2023
|
@EdwardSafford-NOAA your changes look fine, but I can't merge until we figure out the EVA documentation issue (which I am 99% sure is irrelevant to your PR) |
|
Looking into this |
|
Can we try retriggering the tests now? I don't see immediately see the branch for this PR, otherwise I would do an empty commit |
|
@asewnath looks like it's fixed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add level components in a manner similar to channels. Convert channel information into dictionary (like levels), streamline handling of conditional variables related to channel, level, and scan position.
Dependencies
None
Impact
None
Closes #152