Fix plot logo and tight layout bug #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix plot logo & tight layout bugs.
EdwardSafford-NOAA
requested review from
kevindougherty-noaa,
CoryMartin-NOAA and
ADCollard
CoryMartin-NOAA
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Looks good, I want @kevindougherty-noaa to review before merging just to make sure it looks okay
kevindougherty-noaa
approved these changes
Nov 19, 2024
This was referenced Nov 19, 2024
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/obs-monitor
that referenced
this pull request
Nov 20, 2024
With the addition of JCSDA-internal/eva#213 to eva `plot logo` and `tight layout` can now be used again in the yaml template plot files. Note that the `obs-mon` python ve needs to be updated on each machine to pull in the latest version of `eva.` At the moment the `obs-mon` ve is located in my `noscrub` space so I can do that. I've updated the ve on hera, which is where I tested these changes, and update the ve on wcoss2, orion, and hercules this morning. Closes #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the fatal error that results from a batch plot input yaml file containing
plot logoand/ortight layoutfigure settings.As described in #212 the problem is that in
src/eva/plotting/batch/base/plot_tools/figure_driver.pybothplot logoandtight layoutare left in thefigure_confdictionary after the corresponding figure method is correctly applied. Thefigure_confdictionary is eventually fed toemcpyand thenmatplotlibwhich is unable to parse these entries. The fix is to simply remove the entries fromfigure_confonce the requested method has been called.Testing has been done on hera using
src/eva/tests/config/testMonDataSpaceHirs4Metop-A.yaml, which now can plot logos and use tight layout.Closes #212