Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignores cache is dropped when refreshed #17

Closed
JDGrimes opened this issue Nov 14, 2014 · 2 comments
Closed

Ignores cache is dropped when refreshed #17

JDGrimes opened this issue Nov 14, 2014 · 2 comments
Assignees
@JDGrimes
Labels
bug
Milestone
0.2.0

Comments

@JDGrimes
Copy link
Owner

When the ignores cache is refreshed by running the validator with the -c flag set, the previously cached ignores will be dropped from the cache, except those from files which currently have errors. This happens because the cache is completely refreshed each time, but the files without errors won't be parsed at all due to caching.
@JDGrimes JDGrimes added the bug label Nov 14, 2014
@JDGrimes JDGrimes self-assigned this Nov 14, 2014
@JDGrimes JDGrimes added this to the 0.2.0 milestone Nov 14, 2014
@JDGrimes
Copy link
Owner Author

This will cause an error when there's nothing in the cache yet: https://travis-ci.org/JDGrimes/wp-l10n-validator/jobs/42245732

@JDGrimes JDGrimes reopened this Nov 26, 2014
@JDGrimes
Copy link
Owner Author

OK, it looks like I was a bit hasty with the fix there. Let's go for round 3.

@JDGrimes JDGrimes reopened this Nov 26, 2014
@JDGrimes JDGrimes mentioned this issue Feb 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JDGrimes JDGrimes

Labels
bug
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@JDGrimes