-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@JFK344: adapter hand over? #12
Comments
Ah sorry i will add you as a developer to the project |
@git-kick your pull request failed |
The failed checks are outdated versions (node 10, node 12), project's git-hub Actions need to be adjusted to current node versions (16, 18, 20). |
i am not using github very often. More of a Gitlab type of person. How can I give you owner permissions ? @git-kick |
I never did this, sorry. I also have only 1 adapter project, so far. Frankly spoken, if you do not plan to "owner-wise" maintain the current project, I would prefer to crate a new, clean setup. I am thinking about starting from scratch, using the latest adapter creator... |
Hi @JFK344,
I have been using your adapter for more than two years now and I highly appreciate your work. I found some room for improvement, specifically the interruptCp() request I need in my setup. Since you did not answer my PR from Oct 2021, I assume you discontinued work on the evsewifi adapter.
If so, I would suggest to take over and create a new fork or even a new repo (to align the esve/evse mismatch), of course mentioning you as the original creator.
Let me know what you think, thanks
Uli (git-kick)
The text was updated successfully, but these errors were encountered: