Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Custom currency should allow at least 2 decimal places #802

Open
Gadg8eer opened this issue Jan 4, 2025 · 2 comments
Open

[Bug]: Custom currency should allow at least 2 decimal places #802

Gadg8eer opened this issue Jan 4, 2025 · 2 comments

Comments

@Gadg8eer
Copy link
Contributor

Gadg8eer commented Jan 4, 2025

Version of OpenTTD

jgrpp-0.63.3

Expected result

Entering "0.61" into the custom currency field should give ¤0.61 = £1, causing £1 to equal ~¤1.50, in the same way pre-defined NewGRF currencies already (iirc) do.

Actual result

Entering a decimal point to the currency menu does not register in-game. Changing rate = 1 to rate = 0.61 causes the game to give a minor error and set the value to 0.

Steps to reproduce

1a. Open the game to the main menu.
2a. Open Game Options.
3a. Select "Currency > Custom..."
4a. Click the value of the currency to enter a new value.
5a. Type 0-9 and then a decimal point.

...or...

1b. Open openttd.cfg in Notepad++
2b. Find [currency] and change rate to a number with at least one decimal place.
3b. Save the file.
4b. Open the game.

@JGRennison
Copy link
Owner

Currencies are limited to only being an integer multiple of GBP. There isn't any support for fractional multipliers or currency display values smaller than the GBP value.
Any fractional part of currency multipliers set via global settings property 0B is ignored.

@Gadg8eer
Copy link
Contributor Author

Gadg8eer commented Jan 6, 2025

Currencies are limited to only being an integer multiple of GBP. There isn't any support for fractional multipliers or currency display values smaller than the GBP value.
Any fractional part of currency multipliers set via global settings property 0B is ignored.

Ah. That's fair. Thanks for explaining. I'll assume for now that fixing that would be problematic at best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants