Skip to content

Latest commit

 

History

History
56 lines (37 loc) · 1.67 KB

cran-comments.md

File metadata and controls

56 lines (37 loc) · 1.67 KB
Raw

This is a resubmission:

  • http -> https in link to CRAN policies.

Release summary

  • check() now uses --as-cran, suppressing just _R_CHECK_CRAN_INCOMING_ (except during release()). Hopefully this will improve the quality of devtools mediated submissions.

  • Imports needed functions from base packages, eliminating a NOTE.

  • Removes a library() call, eliminating a NOTE.

  • Many other bug fixes and small new features

Test environments

  • local OS X install, R 3.2.1
  • ubuntu 12.04 (on travis-ci), R 3.2.2
  • win-builder (devel and release)

R CMD check results

There were no ERRORs or WARNINGs.

There were 2 NOTEs:

  • checking foreign function calls ... NOTE Evaluating ‘dll$foo’ during check gives error

    This is part of a dynamic check to see if the user can compile packages so dll does not exist during checking.

  • checking R code for possible problems ... NOTE Found the following calls to attach(): File 'devtools/R/package-env.r': attach(NULL, name = pkg_env_name(pkg)) File 'devtools/R/shims.r': attach(e, name = "devtools_shims", warn.conflicts = FALSE)

    These are needed because devtools simulates package loading, and hence needs to attach environments to the search path.

Downstream dependencies

  • I ran R CMD check on all 45 downstream dependencies of devtools. Summary at: https://github.com/hadley/devtools/blob/master/revdep/summary.md

  • There was 1 failure:

    • NMF: this failed in the same way previously. I have reported the issue to the maintainer, but I'm reasonably certain it's not related to devtools.

  • As far as I can tell, there were no new failures related to changes in devtools.